-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Node.js' code coverage/code coverage job #35646
Comments
I believe this has been introduced by #35498. |
@aduh95 thank you! (sorry for looping in the wrong folks, I assumed it was potentially the new URL parser). |
Have we ever tried adding c8 to https://github.com/nodejs/citgm/ ? (I searched for it and I don't think so?) |
we should add it, it isn't included right now afaik. For reference this is the lookup table https://github.com/nodejs/citgm/blob/main/lib/lookup.json |
@joyeecheung @MylesBorins not a bad idea, but it wouldn't have actually caught this, because it only breaks on Node.js' own coverage -- which now has different file paths (c8 would continue working for userland.) |
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
The problem(s)
1. new file paths are breaking the coverage reporting
File paths for Node.js' own files now have this form
node:/internal/cluster/shared_handle
:node:
prefix..js
prefix.I will happily fix this problem in the test reporter, but could someone point me towards where these changes were made (@watilde, @guybedford?) -- I want to make sure I link to the change in the reporter codebase.
2. nightly coverage is broken again
Coverage has been broken for several nights in a row. I believe this is due to an unrelated CI/CD upgrade?
Suggested fix
CC: @nodejs/testing
The text was updated successfully, but these errors were encountered: