Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to io.js from doc #35580

Closed
gireeshpunathil opened this issue Oct 10, 2020 · 4 comments
Closed

remove references to io.js from doc #35580

gireeshpunathil opened this issue Oct 10, 2020 · 4 comments
Labels
good first issue Issues that are suitable for first-time contributors.

Comments

@gireeshpunathil
Copy link
Member

Is your feature request related to a problem? Please describe.

merger happened long back, and predates the earliest supported versions.

Describe the solution you'd like
remove references to io.js from the docs, aiming to reduce confusion.

Describe alternatives you've considered
status-quo.

@aduh95
Copy link
Contributor

aduh95 commented Oct 10, 2020

I was able to find one occurence in Process page:

node/doc/api/process.md

Lines 1764 to 1765 in 83eaaf9

* `name` {string} A value that will always be `'node'` for Node.js. For
legacy io.js releases, this will be `'io.js'`.

Is there more?

@antsmartian
Copy link
Contributor

@aduh95 Yes even I ran a regex found only such instance. I believe this is a good first issue. Tagging it.

@antsmartian antsmartian added the good first issue Issues that are suitable for first-time contributors. label Oct 11, 2020
@hexxdump
Copy link
Contributor

Can I take this and work on fixing the docs ?

@lpinca
Copy link
Member

lpinca commented Oct 26, 2020

Closing as this has been fixed by #35618.

@lpinca lpinca closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Development

No branches or pull requests

5 participants