-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https/http2: random crashes on macOS with simple server #34854
Comments
Does it also happen with binaries from https://nodejs.org/? |
Yes, same with the official v14.8.0 binary from the installer. Also, here's a new signature I've seen while testing. It's so weird.
|
Here's a backtrace of one of the
|
And another from this signature:
Showing all threads in case it matters:
|
Anyone able to reproduce? I can myself reproduce on two machines but I still wonder if this is something about my particular setups. |
I've not been able to reproduce with either v14.8.0 or master. I'm running macOS 10.14.6 and using |
Can't get it to crash using $ wrk -d 5s -c 5000 -t 100 https://localhost:4000
Running 5s test @ https://localhost:4000
100 threads and 5000 connections
Thread Stats Avg Stdev Max +/- Stdev
Latency 93.17ms 182.04ms 1.89s 96.48%
Req/Sec 115.55 279.75 3.49k 96.75%
24935 requests in 5.10s, 3.40MB read
Socket errors: connect 112, read 0, write 0, timeout 829
Requests/sec: 4887.93
Transfer/sec: 682.59KB $ npx autocannon -d 5 -c 300 -p 10 https://localhost:4000
Running 5s test @ https://localhost:4000
300 connections with 10 pipelining factor
┌─────────┬──────┬──────┬───────┬───────┬──────────┬──────────┬───────────┐
│ Stat │ 2.5% │ 50% │ 97.5% │ 99% │ Avg │ Stdev │ Max │
├─────────┼──────┼──────┼───────┼───────┼──────────┼──────────┼───────────┤
│ Latency │ 0 ms │ 4 ms │ 35 ms │ 65 ms │ 10.27 ms │ 18.47 ms │ 325.29 ms │
└─────────┴──────┴──────┴───────┴───────┴──────────┴──────────┴───────────┘
┌───────────┬────────┬────────┬─────────┬─────────┬─────────┬─────────┬────────┐
│ Stat │ 1% │ 2.5% │ 50% │ 97.5% │ Avg │ Stdev │ Min │
├───────────┼────────┼────────┼─────────┼─────────┼─────────┼─────────┼────────┤
│ Req/Sec │ 25871 │ 25871 │ 29215 │ 30927 │ 28888 │ 1686.95 │ 25867 │
├───────────┼────────┼────────┼─────────┼─────────┼─────────┼─────────┼────────┤
│ Bytes/Sec │ 3.7 MB │ 3.7 MB │ 4.18 MB │ 4.42 MB │ 4.13 MB │ 241 kB │ 3.7 MB │
└───────────┴────────┴────────┴─────────┴─────────┴─────────┴─────────┴────────┘
Req/Bytes counts sampled once per second.
144k requests in 5.22s, 20.7 MB read |
Something odd I noticed: If I set |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Probably not related unless your crash signatures are random, like mine. |
Ok, sorry for driving you away 😅 I'll mark my comments as off topic then and will create a new issue. |
Does not reproduce anymore using node v18.8.0. |
What steps will reproduce the bug?
Save and run the script and in a second terminal create some load:
Server should consistently crash within a few seconds.
How often does it reproduce? Is there a required condition?
Every time
What is the expected behavior?
To not crash
What do you see instead?
It will crash with seemingly random crash signatures. Some examples:
Additional information
I don't see the crashes when using
http
, only when usinghttps
orhttp2
modules. Also I could not reproduce on Linux or Windows. Node was installed using Homebrew.Crash does not happen with
res.end("ok")
, only withres.write("ok"); res.end()
.The text was updated successfully, but these errors were encountered: