Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 4.2.0 encoding problems #3382

Closed
ghost opened this issue Oct 15, 2015 · 8 comments
Closed

Node.js 4.2.0 encoding problems #3382

ghost opened this issue Oct 15, 2015 · 8 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. http Issues or PRs related to the http subsystem.

Comments

@ghost
Copy link

ghost commented Oct 15, 2015

I made a request to vkontakte.ru api to send notification to user with Russian language text.
Notification was sent with text: "Denis ?@8a;0 B515 315"

My code works fine with Node 0.10.38, 0.12.7

@ChALkeR
Copy link
Member

ChALkeR commented Oct 15, 2015

@lucky-libora Could you share an example code to reproduce the issue?
You could remove the url and all the sensitive data.

@ChALkeR ChALkeR added the http Issues or PRs related to the http subsystem. label Oct 15, 2015
@Fishrock123
Copy link
Contributor

Is this related to #962 and #1693? Are you sure it runs correctly on 4.1.2?

@ghost
Copy link
Author

ghost commented Oct 16, 2015

@Fishrock123 yep, you are right. It is related bug and doesn't work correctly on Node 4.1.2

@seishun
Copy link
Contributor

seishun commented Oct 16, 2015

@lucky-libora please provide a test case.

@trevnorris
Copy link
Contributor

@seishun Send a non latin-1 character as a header to a node server then inspect the header. It's one-byte decoded and will show up as gibberish.

@seishun
Copy link
Contributor

seishun commented Oct 16, 2015

@trevnorris it seems it's not the problem described in the issue. @lucky-libora is sending a request, not receiving one.

@trevnorris
Copy link
Contributor

In certain cases outgoing writes will be interpreted as binary, instead of utf8. there's an inconsistency that hasn't been addresses. Probably the cause of this.

@ChALkeR
Copy link
Member

ChALkeR commented Feb 15, 2016

No activity, no testcase.
Looks like a duplicate of either #1693 or #2114.

@ChALkeR ChALkeR closed this as completed Feb 15, 2016
@ChALkeR ChALkeR added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants