fs: bad error message in fs.openSync

[ronkorving]

Calling:

fs.openSync(path, { flags: 'w' });

Throws: TypeError: flags must be an int from native land.
While on the C++ side, that may be correct, in JavaScript land, the 2nd argument is not an int but a string.

In other words, yes, me passing an object was bad, but the error informed me to do the wrong thing compared to what the docs say.

[reqshark]

fs flags are a string, not object, like going require('fs').readFile(dude, 'utf8', cb)

console.log(require('fs').openSync('what.js', 'w'))

[reqshark]

but yea the error definitely says int when you give it objects

[yjhjstz]

should we throw new Error('Unknown file open flag: ' + flag); in stringToFlags?

[ronkorving]

I think it should throw a TypeError if not string and not integer (Number.isInteger is now at our disposal). However, this is also used in the asynchronous fs.open, so we need to be careful with exceptions.

In fact, I just realized that's already broken in fs.open and fs.readFile, since stringToFlags already throws. See Line 251 and Line 541.

[ronkorving]

I'll conjure up a PR to fix this.

[jasnell]

Fixed by #5590