You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just leaving this here for now because I don't have time to chase it down... vcbuild lint on Windows is linting the cctest/gtest tool but it shouldn't be. /cc @nodejs/platform-windows
λ vcbuild lint
running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\js-native-api\*.cc test\js-native-api\*.cc test\js-native-api\*.h test\node-api\*.cc test\node-api\*.cc test\node-api\*.h test\cctest\*.cc test\cctest\*.h tools\icu\*.cc tools\icu\*.h'
test\cctest\gtest\gtest-all.cc:436: "stdlib.h" already included at test\cctest\gtest\gtest-all.cc:315 [build/include] [4]
test\cctest\gtest\gtest-all.cc:439: "algorithm" already included at test\cctest\gtest\gtest-all.cc:320 [build/include] [4]
test\cctest\gtest\gtest-all.cc:442: "vector" already included at test\cctest\gtest\gtest-all.cc:327 [build/include] [4]
test\cctest\gtest\gtest-all.cc:781: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:781: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1965: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1966: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1984: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4829: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4873: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4877: Use left leaning pointer instead of right leaning [readability/pointer_notation] [2]
...
The text was updated successfully, but these errors were encountered:
jasnell
added
windows
Issues and PRs related to the Windows platform.
build
Issues and PRs related to build files or the CI.
labels
Jun 6, 2019
Just leaving this here for now because I don't have time to chase it down...
vcbuild lint
on Windows is linting the cctest/gtest tool but it shouldn't be. /cc @nodejs/platform-windowsThe text was updated successfully, but these errors were encountered: