Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/lint on Windows is slightly broken #28086

Closed
jasnell opened this issue Jun 6, 2019 · 0 comments · Fixed by #28102
Closed

build/lint on Windows is slightly broken #28086

jasnell opened this issue Jun 6, 2019 · 0 comments · Fixed by #28102
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@jasnell
Copy link
Member

jasnell commented Jun 6, 2019

Just leaving this here for now because I don't have time to chase it down... vcbuild lint on Windows is linting the cctest/gtest tool but it shouldn't be. /cc @nodejs/platform-windows

λ vcbuild lint
running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\js-native-api\*.cc test\js-native-api\*.cc test\js-native-api\*.h test\node-api\*.cc test\node-api\*.cc test\node-api\*.h test\cctest\*.cc test\cctest\*.h tools\icu\*.cc tools\icu\*.h'
test\cctest\gtest\gtest-all.cc:436:  "stdlib.h" already included at test\cctest\gtest\gtest-all.cc:315  [build/include] [4]
test\cctest\gtest\gtest-all.cc:439:  "algorithm" already included at test\cctest\gtest\gtest-all.cc:320  [build/include] [4]
test\cctest\gtest\gtest-all.cc:442:  "vector" already included at test\cctest\gtest\gtest-all.cc:327  [build/include] [4]
test\cctest\gtest\gtest-all.cc:781:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:781:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1965:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1966:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1984:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4829:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4873:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4877:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
...
@jasnell jasnell added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Jun 6, 2019
refack added a commit to refack/node that referenced this issue Jun 13, 2019
* look for GNU Make in the Path or use wsl

PR-URL: nodejs#28102
Fixes: nodejs#28086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>
BridgeAR pushed a commit that referenced this issue Jun 17, 2019
* look for GNU Make in the Path or use wsl

PR-URL: #28102
Fixes: #28086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant