Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.table splits long strings and breaks formatting in node v12 #27915

Closed
kroleg opened this issue May 26, 2019 · 2 comments
Closed

console.table splits long strings and breaks formatting in node v12 #27915

kroleg opened this issue May 26, 2019 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs. console Issues and PRs related to the console subsystem.

Comments

@kroleg
Copy link

kroleg commented May 26, 2019

  • Version: v12.0 and onwards (checked 12.3.1)
  • Platform: Darwin 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64
  • Subsystem: console

Starting with node v12.0 console.table breaks table by splitting long strings with pluses and new lines.

You can easily reproduce it:

nvm install 12.0 # or nvm use 12.0
node -e "console.table([{name:'very long long long long long long long long long long long long long long long'}])"

Снимок экрана 2019-05-26 в 22 19 31

nvm install 10.15.3 # or nvm use 10.15.3
node -e "console.table([{name:'very long long long long long long long long long long long long long long long'}])"

Снимок экрана 2019-05-26 в 22 19 58

nvm install 11.15.0 # or nvm use 11.15.0
node -e "console.table([{name:'very long long long long long long long long long long long long long long long'}])"

Снимок экрана 2019-05-26 в 22 18 57

Unfortunately i am not able to find a source of issue because code looks too complicated to me.
@addaleax
Copy link
Member

@BridgeAR

@devsnek
Copy link
Member

devsnek commented May 26, 2019

another good reason to restore the previous formatting default

@devsnek devsnek added confirmed-bug Issues with confirmed bugs. console Issues and PRs related to the console subsystem. labels May 26, 2019
mscdex added a commit to mscdex/io.js that referenced this issue May 26, 2019
@mscdex
console: fix table() output
4f51c20 
Fixes: nodejs#27915
@mscdex mscdex mentioned this issue May 26, 2019
Closed
3 tasks
@cjihrig cjihrig mentioned this issue May 26, 2019
Closed
@Trott Trott closed this as completed in b8bdf0e May 30, 2019
targos pushed a commit that referenced this issue May 31, 2019
@mscdex @targos
console: fix table() output
449ee8d 
Fixes: #27915

PR-URL: #27917
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@runjak runjak mentioned this issue Aug 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

console: fix table() output mscdex/io.js
3 participants
@kroleg @addaleax @devsnek