node-gyp fails with node v4 on windows

[luisrudge]

with node:latest on windows, running npm i c3 fails every time.

websockets/bufferutil#15
websockets/utf-8-validate#13
brianmcd/contextify#177

[cjihrig]

I haven't tested on Windows, but npm i bufferutil worked for me, while npm i [email protected] (which is the version reported in the issue) does not. It seems to use an older version of nan. Looks to be a similar situation for the other issues.

[ronkorving]

Latest bufferutil uses the latest NAN and breaks on Node 4.

[mscdex]

@luisrudge @ronkorving The issue with bufferutil in particular is that the upstream project(s) have not updated their dependencies so that bufferutil 1.2.x is picked up, which is what has nan 2.x support (not bufferutil 1.1.0).

So currently that means that engine.io-client needs to bump ws to v0.8.0, then afterwards socket.io-client needs to bump engine.io-client, then socket.io needs to bump socket.io-client.

[ronkorving]

I'm already on ws v0.8. Still broken, and it wasn't on iojs v3

[mscdex]

@ronkorving npm install ws works just fine for me with node v4 on Windows. However what I meant earlier was that for socket.io specifically, its dependency chain has to be updated yet to use ws v0.8.

[ronkorving]

Sure, but that's not the problem here (I'm not even using socket.io, I use ws directly). This is a real problem, but I haven't been able to determine where its origin is. See websockets/bufferutil#15 (comment)

[bnoordhuis]

I'm going to close this because it's almost certainly not an issue with node core.