Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.trace not printing stack #26763

Closed
accerqueira opened this issue Mar 19, 2019 · 3 comments
Closed

console.trace not printing stack #26763

accerqueira opened this issue Mar 19, 2019 · 3 comments
Assignees
@BridgeAR
Labels
confirmed-bug Issues with confirmed bugs. console Issues and PRs related to the console subsystem.

Comments

@accerqueira
Copy link

  • Version:
    v11.11.0

  • Platform:
    Linux zeratul 4.18.0-15-generic ENOTFOUND and ECONNRESET errors #16-Ubuntu SMP Thu Feb 7 10:56:39 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

  • Subsystem:
    console

The following code seems to print a stack trace on v11.10.1 but not on v11.11.0 and v11.12.0

console.trace('show me');

Output on v11.10.1:

Trace: show me
    at Object.<anonymous> (/tmp/console-trace-no-stack.js:1:71)
    at Module._compile (internal/modules/cjs/loader.js:738:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:749:10)
    at Module.load (internal/modules/cjs/loader.js:630:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
    at Function.Module._load (internal/modules/cjs/loader.js:562:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:801:12)
    at internal/main/run_main_module.js:21:11

Output on v11.11.0 and v11.12.0

Trace: show me
@accerqueira
Copy link
Author

Is that a current branch thing? Or maybe there is some environment variable that I need to set, for this to work?

@devsnek
Copy link
Member

devsnek commented Mar 19, 2019

cc @BridgeAR

@BridgeAR BridgeAR added confirmed-bug Issues with confirmed bugs. console Issues and PRs related to the console subsystem. labels Mar 19, 2019
@BridgeAR
Copy link
Member

This is a recent regression. Thank's for reporting this!

@BridgeAR BridgeAR self-assigned this Mar 19, 2019
BridgeAR added a commit to BridgeAR/node that referenced this issue Mar 19, 2019
@BridgeAR
console: fix trace function
7306eef 
A recent refactoring made the slight mistake of calling `trace()`
instead of `this.trace()`.

Fixes: nodejs#26763
@BridgeAR BridgeAR mentioned this issue Mar 19, 2019
Closed
4 tasks
targos pushed a commit to targos/node that referenced this issue Mar 27, 2019
@BridgeAR @targos
console: fix trace function
6e16980 
A recent refactoring made the slight mistake of calling `trace()`
instead of `this.trace()`.

PR-URL: nodejs#26764
Fixes: nodejs#26763
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
targos pushed a commit that referenced this issue Mar 27, 2019
@BridgeAR @targos
console: fix trace function
e49cd40 
A recent refactoring made the slight mistake of calling `trace()`
instead of `this.trace()`.

PR-URL: #26764
Fixes: #26763
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BridgeAR BridgeAR

Labels
confirmed-bug Issues with confirmed bugs. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

console: fix trace function BridgeAR/node
3 participants
@accerqueira @devsnek @BridgeAR