Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky test-inspector-debug-end on AIX #25047

Closed
Trott opened this issue Dec 14, 2018 · 3 comments
Closed

investigate flaky test-inspector-debug-end on AIX #25047

Trott opened this issue Dec 14, 2018 · 3 comments
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol

Comments

@Trott
Copy link
Member

Trott commented Dec 14, 2018

https://ci.nodejs.org/job/node-test-commit-aix/19716/nodes=aix61-ppc64/console

test-osuosl-aix61-ppc64_be-1

09:58:13 not ok 2436 sequential/test-inspector-debug-end
09:58:13   ---
09:58:13   duration_ms: 1.178
09:58:13   severity: fail
09:58:13   exitcode: 1
09:58:13   stack: |-
09:58:13     Test there's no crash stopping server that was not started
09:58:13     { AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
09:58:13     
09:58:13     42 !== null
09:58:13     
09:58:13         at testNoServerNoCrash (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-inspector-debug-end.js:13:3)
09:58:13         at process.internalTickCallback (internal/process/next_tick.js:77:7)
09:58:13       generatedMessage: true,
09:58:13       name: 'AssertionError [ERR_ASSERTION]',
09:58:13       code: 'ERR_ASSERTION',
09:58:13       actual: 42,
09:58:13       expected: null,
09:58:13       operator: 'strictEqual' }
09:58:13     1
09:58:13   ...
@Trott Trott added inspector Issues and PRs related to the V8 inspector protocol aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Dec 14, 2018
@Trott
Copy link
Member Author

Trott commented Dec 18, 2018

Still happening (recent example below) but infrequently enough that I won't mark it flaky yet, especially because I'm optimistic it will be fixed by whatever combination of things addresses #25007.

test-osuosl-aix61-ppc64_be-1

https://ci.nodejs.org/job/node-test-commit-aix/19840/nodes=aix61-ppc64/console

04:32:59 not ok 2443 sequential/test-inspector-debug-end
04:32:59   ---
04:32:59   duration_ms: 1.200
04:32:59   severity: fail
04:32:59   exitcode: 1
04:32:59   stack: |-
04:32:59     Test there's no crash stopping server that was not started
04:32:59     { AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
04:32:59     
04:32:59     42 !== null
04:32:59     
04:32:59         at testNoServerNoCrash (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-inspector-debug-end.js:13:3)
04:32:59         at process.internalTickCallback (internal/process/next_tick.js:77:7)
04:32:59       generatedMessage: true,
04:32:59       name: 'AssertionError [ERR_ASSERTION]',
04:32:59       code: 'ERR_ASSERTION',
04:32:59       actual: 42,
04:32:59       expected: null,
04:32:59       operator: 'strictEqual' }
04:32:59     1
04:32:59   ...

@gireeshpunathil
Copy link
Member

got a core file today.

(dbx) where
.() at 0x0
array-buffer-collector._ZN2v88internal20CancelableLambdaTaskIZNS0_20ArrayBufferCollector15FreeAllocationsEvEUlvE_E11RunInternalEv(??) at 0x1011caca4
cancelable-task.LTHUNK..0(??) at 0x100039304
node_platform._ZN4node12_GLOBAL__N_1L20PlatformWorkerThreadEPv(??) at 0x1001e6970
(dbx) ($link-4)/i
0x1011caca4 (_ZN2v88internal20CancelableLambdaTaskIZNS0_20ArrayBufferCollector15FreeAllocationsEvEUlvE_E11RunInternalEv+0x36c) 4e800421       bctrl
(dbx) x
  $r0:0x00000001011cac10  $stkp:0x00000001102b2480   $toc:0x0000000000000000  
  $r3:0x000000011023e9b0    $r4:0x0000000101f78220    $r5:0x0000000000ee1e7e  
  $r6:0x0037710155f3a70b    $r7:0x000000000000007d    $r8:0x000000000000007d  
  $r9:0x0000000000000000   $r10:0x0000000000000000   $r11:0x0000000000000000  
 $r12:0x09001000a0082b60   $r13:0x00000001102ba800   $r14:0x0000000000000000  
 $r15:0x0000000000000000   $r16:0x0000000000000000   $r17:0x0000000000000000  
 $r18:0x0000000000000000   $r19:0x0000000000000000   $r20:0x0000000000000000  
 $r21:0x0000000000000000   $r22:0x0000000000000000   $r23:0x0000000000000000  
 $r24:0x0000000000000000   $r25:0x000000011023f300   $r26:0x0000000000000000  
 $r27:0x000000011023ff50   $r28:0x00000001101fb220   $r29:0x0000000110420790  
 $r30:0x0000000000000000   $r31:0x00000001102b2480  
 $iar:0x0000000000000000   $msr:0xa00000000000d032    $cr:0x42000228  
$link:0x00000001011caca8   $ctr:0x0000000000000000   $xer:0x40000000  
(dbx) 

So it is clearly a wild branch that we saw in #24921 . Resolving #25007 should be the way forward. I will submit one to mark this flaky.

gireeshpunathil added a commit to gireeshpunathil/node that referenced this issue Dec 19, 2018
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in nodejs#25007
Mart these  as flaky in AIX until that is resolved.

Refs: nodejs#25047
Refs: nodejs#25029
gireeshpunathil added a commit that referenced this issue Dec 28, 2018
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this issue Jan 1, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in nodejs#25007
Mart these  as flaky in AIX until that is resolved.

Refs: nodejs#25047
Refs: nodejs#25029

PR-URL: nodejs#25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@gireeshpunathil
Copy link
Member

the test is active for the last one week with no failures, so as expected #25061 has fixed the underlying issue. Closing.

BethGriggs pushed a commit that referenced this issue Apr 17, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 28, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs pushed a commit that referenced this issue May 10, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this issue May 16, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

2 participants