http/2 compat will emit finish before end() for HEAD requests

[ronag]

i.e. this breaks for HEAD requests:

server.on('request', (req, res) => {
  res.on('finish', common.mustCall()) // Fail
  res.on('close', common.mustCall())  // Fail
  res.end()
})

[ronag]

Probably duplicate #24743

[rexagod]

@ronag Please correct me if I'm wrong but I think this issue and the duplicate one both are fixed now. I tried reproducing them using the code below. The code passes.

const http = require('http');
const assert = require('assert');

const server = http.createServer();

server.listen(0);

server.on('listening', (res) => {
  const clientrequest = http.request({
    port: server.address().port,
    method: 'HEAD',
    path: '/'
  });
  clientrequest.end();
});

server.on('request', (req, res) => {

  // #24743
  assert(!res.finished);

  // #24742
  res.on('finish', () => { console.log('finish') });
  res.on('close', () => { console.log('close') });

  res.end();
  server.close();
});

[jasnell]

@ronag is this still an issue?

[ronag]

Probably not. Though I don't remember what caused the original issue and what might have fixed it.