Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky parallel/test-crypto-keygen #23406

Closed
Trott opened this issue Oct 10, 2018 · 7 comments · Fixed by #23430
Closed

Investigate flaky parallel/test-crypto-keygen #23406

Trott opened this issue Oct 10, 2018 · 7 comments · Fixed by #23430
Labels
crypto Issues and PRs related to the crypto subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@Trott
Copy link
Member

Trott commented Oct 10, 2018

https://ci.nodejs.org/job/node-test-binary-arm/3782/RUN_SUBSET=5,label=pi1-docker/console

20:47:00 not ok 58 parallel/test-crypto-keygen
20:47:00   ---
20:47:00   duration_ms: 360.113
20:47:00   severity: fail
20:47:00   exitcode: -15
20:47:00   stack: |-
20:47:00     timeout
20:47:00   ...
@Trott
Copy link
Member Author

Trott commented Oct 10, 2018

If we continue to see this: The duration this test takes to run on Pi1 devices suggests that maybe it should be broken up into smaller tests if possible? Or skipped on devices that don't have a lot of memory and/or CPU?

https://ci.nodejs.org/job/node-test-binary-arm/3787/RUN_SUBSET=1,label=pi1-docker/console

00:56:36 ok 58 parallel/test-crypto-keygen
00:56:36   ---
00:56:36   duration_ms: 86.2
00:56:36   ...

@Trott
Copy link
Member Author

Trott commented Oct 10, 2018

Previous: #22978

@sam-github
Copy link
Contributor

I don't think its memory intensive, but keygen is cpu intensive. crypto in general can be.

Breaking it up might be the right thing to do, if we can't annotate the test to allow more time.

@bnoordhuis
Copy link
Member

That test searches for suitable large primes, which is CPU-intensive and non-determinate. e4e5b13 fixed the same issue for the Diffie-Hellman tests (where it also manifested on the Pi1s) by narrowing the search space from 1024 to 256 bits.

@bnoordhuis bnoordhuis added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 10, 2018
@tniessen tniessen added the crypto Issues and PRs related to the crypto subsystem. label Oct 10, 2018
@tniessen
Copy link
Member

cc @nodejs/crypto (mostly to test something on GitHub, sorry for the notification)

@sam-github
Copy link
Contributor

I started a branch to reduce key strengths in test locally, but didn't have enough time and laptop power to build.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2018

https://ci.nodejs.org/job/node-test-binary-arm/3870/RUN_SUBSET=1,label=pi1-docker/console

00:25:11 not ok 58 parallel/test-crypto-keygen
00:25:11   ---
00:25:11   duration_ms: 360.106
00:25:11   severity: fail
00:25:11   exitcode: -15
00:25:11   stack: |-
00:25:11     timeout
00:25:11   ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants