Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: should win_delay_load_hook be removed? #23253

Closed
JCMais opened this issue Oct 4, 2018 · 4 comments
Closed

build: should win_delay_load_hook be removed? #23253

JCMais opened this issue Oct 4, 2018 · 4 comments
Labels
addons Issues and PRs related to native addons. build Issues and PRs related to build files or the CI. question Issues that look for answers. tools Issues and PRs related to the tools directory.

Comments

@JCMais
Copy link
Contributor

JCMais commented Oct 4, 2018

It was added here efadffe

And looks like it was too specific to a problem when we had iojs still going, is that still needed?

@Fishrock123 Fishrock123 added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. question Issues that look for answers. labels Oct 5, 2018
@richardlau richardlau added the addons Issues and PRs related to native addons. label Oct 13, 2018
@richardlau
Copy link
Member

nodejs/node-gyp#1566 is extending win_delay_load_hook for electron, so it probably is still needed.

@richardlau
Copy link
Member

cc @nodejs/node-gyp

@refack
Copy link
Contributor

refack commented Oct 13, 2018

AFAIU it's needed for when the host executable is renamed. We do want precompiled binaries to be maximally compatible, so if this still fixes that scenario I'd say, keep it.

@JCMais
Copy link
Contributor Author

JCMais commented Oct 17, 2018

Had forgot about Electron, looks like it's still required then, and will stay that way. I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. build Issues and PRs related to build files or the CI. question Issues that look for answers. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

4 participants