Replace test-buffer-bindingobj-no-zerofill.js by an addon test #22547
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
test
Issues and PRs related to the tests.
Now the
test/parallel/test-buffer-bindingobj-no-zerofill.js
uses monkey-patches to simulate the situation whensetupBufferJS()
has an undefined zeroFill.node/test/parallel/test-buffer-bindingobj-no-zerofill.js
Lines 29 to 34 in 49bfc37
But the monkey-patches are little bit tricky and crash the tests when we move buffer module to internalBinding (#22370 (comment))
We need replace it by a C++ addon test now. See conversation at 27e84ddd4e1#r19182129 and #11706.
/cc @Trott @bnoordhuis
The text was updated successfully, but these errors were encountered: