-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns.promises test coverage is poor #22471
Comments
#21559 should partially (?) fix this, I presume. |
Willing to work towards this, with some mentoring/help. For example, would a |
@ChALkeR I will be happy to contribute in this issue. |
It's considerably less poor now that we run I'd welcome someone getting those last 3 branches covered, but I think this can nonetheless be closed at this time. |
I'm going to close this. Feel free to re-open if you think that's not warranted at this time, @ChALkeR. |
Ref: #20435 (comment)
Experimental
dns/promises
API is present in the currentmaster
without proper test coverage.According to the coverage report, the following functions are not tested at all:
onlookup
onlookupall
onlookupservice
createLookupServicePromise
While inspecting the experimental
fs.promises
, there were also some implementation bugs found that could have been caught by code coverage, see e.g. #20407. Thedns.promises
is much smaller in lines of code, but it is still possible that it contains bugs that could be noticed by extending coverage.The text was updated successfully, but these errors were encountered: