-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested HTTP/2 pushStream fails with error #19095
Comments
A push stream cannot be the parent of another push stream. Specifically, a server is only permitted to send a PUSH_PROMISE frame on a client initiated stream. |
A better error message here would be good. |
I figured that would be the case but, although I don't show it, after checking the value of pushallowed which came back true, I figured why not try. |
Thanks for the quick response though. I can quit banging my head against that brick wall. @jasnell Should I leave this open or close the issue? |
Let's leave this open. Some API and doc improvements would be worthwhile |
@jasnell Thanks, I ran into this issue again just the other day. You're a rockstar!! |
Fixes: #19095 PR-URL: #22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: nodejs#19095 PR-URL: nodejs#22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: nodejs#19095 PR-URL: nodejs#22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: #19095 Backport-PR-URL: #22850 PR-URL: #22245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Version: 9.7.1
Platform: 64-bit (Windows)
Subsystem: http/2
The nested pushStream callback argument (err) is populated with this:
The text was updated successfully, but these errors were encountered: