-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: move node-report into core #18760
Comments
+1. |
+1 |
2 similar comments
+1 |
+1 |
Some previous discussion in nodejs/node-report#103. |
I'd be ok with this but it will need to modifications to default behavior and also perhaps other things. Also, the api would have to be not exposed as a separate module. I propose we do not attempt to expose the JS api until the other parts are implemented. |
I agree with not exposing the js API as a separate module. A function off util or console should work fine. There are definitely a few internal bits that will need to be looked at also. |
+1 |
1 similar comment
+1 |
I think what we have talked about at the summit was, first putting |
One thing we need to discuss: how is the test CI integration of node-report going to work? Right now it does not have a testing CI I believe. During the summit we talked about vendoring it in like |
In addition to the CI for testing node-report itself it is also included in CITGM runs. |
+1 |
Make node-report part of core runtime, to satisfy its tier1 status on diagnostic tooling. No new functionalities have been added, changes that are required for melding it as a built-in capability has been affected on the module version of node-report (https://github.com/nodejs/node-report) Refs: nodejs#19661 Refs: nodejs#18760 Refs: nodejs/node-report#103
Make node-report part of core runtime, to satisfy its tier1 status on diagnostic tooling. No new functionalities have been added, changes that are required for melding it as a built-in capability has been affected on the module version of node-report (https://github.com/nodejs/node-report) Refs: nodejs#19661 Refs: nodejs#18760 Refs: nodejs/node-report#103
Make node-report part of core runtime, to satisfy its tier1 status on diagnostic tooling. No new functionalities have been added, changes that are required for melding it as a built-in capability has been affected on the module version of node-report (https://github.com/nodejs/node-report) Refs: nodejs#19661 Refs: nodejs#18760 Refs: nodejs/node-report#103
Make node-report part of core runtime, to satisfy its tier1 status on diagnostic tooling. No new functionalities have been added, changes that are required for melding it as a built-in capability has been affected on the module version of node-report (https://github.com/nodejs/node-report) Refs: nodejs#19661 Refs: nodejs#18760 Refs: nodejs/node-report#103
It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. (Or, perhaps better, open a PR or get the existing one at #22712 moving.) I'm just tidying up and not acting on a super-strong opinion or anything like that. |
22712 is on track, just that I am low on bandwidth at the moment, went with some open libuv issues that were causing CI failures. 22712 should come to life soon. |
#22712 is merged now; so closing. fyi - @nodejs/diagnostics |
The idea of moving
node-report
was brought up at the Diagnostics Summit.Thoughts? Objections?
The text was updated successfully, but these errors were encountered: