Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does v9.4.0 support dynamic import()? #18202

Closed
zhanzhenzhen opened this issue Jan 17, 2018 · 3 comments
Closed

Does v9.4.0 support dynamic import()? #18202

zhanzhenzhen opened this issue Jan 17, 2018 · 3 comments

Comments

@zhanzhenzhen
Copy link
Contributor

zhanzhenzhen commented Jan 17, 2018

I see the v9.x doc says "Dynamic import can also be used with the flag --harmony-dynamic-import to create entry points into ESM graphs at run time." But when I try, it gives an "Unsupported" promise rejection.

@targos targos mentioned this issue Jan 17, 2018
2 tasks
@targos
Copy link
Member

targos commented Jan 17, 2018

Thanks for the report. The problem is that the documentation change landed too soon. The PR to add support for dynamic import back to v9.x is still open: #17823. It will probably be merged before the next release.

@benjamingr
Copy link
Member

Yes, this is a mistake, @MylesBorins opened a PR to fix it -
see #18141

@benjamingr
Copy link
Member

Going to close this as #18141 landed - thank you so much for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants