Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --perf-prof an --perf-basic-prof in NODE_OPTIONS #17571

Closed
dottedmag opened this issue Dec 9, 2017 · 4 comments
Closed

Allow --perf-prof an --perf-basic-prof in NODE_OPTIONS #17571

dottedmag opened this issue Dec 9, 2017 · 4 comments
Labels
cli Issues and PRs related to the Node.js command line interface. feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors.

Comments

@dottedmag
Copy link

Profiling Node.js programs which spawn another Node.js processes using Linux prof is unnecessarily hard: new processes use executable from the parent process, so it is not possible to add a shell wrapper around Node to add --perf-prof to a subprocess, one has to find all the places where subprocesses are spawned and add the argument there.

NODE_OPTIONS is perfect for this task (just run the top-level process with it and all subtree will emit profiling data), but it does not support --perf-prof or --perf-basic-prof at the moment.

Please add it.
@addaleax addaleax added cli Issues and PRs related to the Node.js command line interface. feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors. labels Dec 10, 2017
@Leko Leko mentioned this issue Dec 11, 2017
Closed
3 tasks
@juggernaut451
Copy link
Contributor

is this issue stil open @dottedmag ?

@dottedmag
Copy link
Author

Yes, it is. #17600 is not yet merged, and there is no --perf-prof/--perf-basic-prof in whitelist in src/node.cc.

@juggernaut451
Copy link
Contributor

#17600 is still open. Making another PR would not be a good option until it is rejected

@TimothyGu
Copy link
Member

Fixed in #17600.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow --perf-prof and --perf-basic-prof in NODE_OPTIONS
4 participants
@dottedmag @addaleax @TimothyGu @juggernaut451