Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undocumented global object aliases. #1747

Closed
jdalton opened this issue May 20, 2015 · 7 comments
Closed

Remove undocumented global object aliases. #1747

jdalton opened this issue May 20, 2015 · 7 comments
Labels
semver-major PRs that contain breaking changes and should be released in the next major version.

Comments

@jdalton
Copy link
Member

jdalton commented May 20, 2015

There are a couple of undocumented global object aliases root and GLOBAL that could be removed. I've stumbled on root in lodash that was interesting to debug.
@Fishrock123 Fishrock123 mentioned this issue May 20, 2015
Closed
@rlidwka
Copy link
Contributor

rlidwka commented May 20, 2015

nodejs/node-v0.x-archive#8156

+1

@silverwind silverwind added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 20, 2015
@silverwind
Copy link
Contributor

I think GLOBAL was the initial global object name, so there might be some ancient code that relies on it. Would love to see some npm stats for usage on these two.

@ChALkeR
Copy link
Member

ChALkeR commented May 26, 2015

Should be linked with this: #1794
Once #1794 gets merged, this will need alterations in the .eslintrc file.

Edit: Ah, this is not a PR, sorry. ☺

@silverwind
Copy link
Contributor

@JacksonTian care to port nodejs/node-v0.x-archive#8156 to io.js?

@JacksonTian
Copy link
Contributor

Ok.

@JacksonTian
Copy link
Contributor

The new PR is here #1838.

@jasnell
Copy link
Member

jasnell commented Mar 9, 2016

Closing this since #1838 landed.

@jasnell jasnell closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jdalton @silverwind @ChALkeR @JacksonTian @jasnell @rlidwka