Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI status in PR differs from status in ci.nodejs.org #17387

Closed
vsemozhetbyt opened this issue Nov 29, 2017 · 5 comments
Closed

CI status in PR differs from status in ci.nodejs.org #17387

vsemozhetbyt opened this issue Nov 29, 2017 · 5 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 29, 2017

#17345

PR status: All checks have passed. 13 successful checks

ci.nodejs.org status: one failure (centos6-64), one machine (freebsd10-64) still running (https://ci.nodejs.org/job/node-test-commit/14457/)

P.S. Now the status has suddenly turned into "1 pending and 12 successful checks".
P.P.S Now it is "All checks have passed. 13 successful checks" again, but we still have that one failure.

@vsemozhetbyt vsemozhetbyt added the build Issues and PRs related to build files or the CI. label Nov 29, 2017
@Fishrock123
Copy link
Contributor

@vsemozhetbyt did you try hard reloading the page?

Also I don't see CI status on any of that PR's commits?

@vsemozhetbyt
Copy link
Contributor Author

@Fishrock123 Yes, I tried several times. Now, after landing and closing, the status is gone in the PR, but it was all green in the end (despite the last https://ci.nodejs.org/job/node-test-pull-request/11798/). Should I close this issue until something similar happens?

@refack
Copy link
Contributor

refack commented Nov 30, 2017

We still have a race problem with the status updates:

  1. One of the linux variants fail
  2. GitHub reports fail
  3. Another linux variant succeeds
  4. GitHub reports success

/CC @maclover7 @gibfahn IMHO simplest fix is to report on completion of node-test-commit

@apapirovski
Copy link
Member

@maclover7 @refack @gibfahn any news on this? Does it work as expected now or is there still a race condition?

@refack
Copy link
Contributor

refack commented Apr 13, 2018

node-test-commit does report it's status now so this can be closed
image

@refack refack closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

4 participants