-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI status in PR differs from status in ci.nodejs.org #17387
Comments
@vsemozhetbyt did you try hard reloading the page? Also I don't see CI status on any of that PR's commits? |
@Fishrock123 Yes, I tried several times. Now, after landing and closing, the status is gone in the PR, but it was all green in the end (despite the last https://ci.nodejs.org/job/node-test-pull-request/11798/). Should I close this issue until something similar happens? |
We still have a race problem with the status updates:
/CC @maclover7 @gibfahn IMHO simplest fix is to report on completion of |
@maclover7 @refack @gibfahn any news on this? Does it work as expected now or is there still a race condition? |
#17345
PR status: All checks have passed. 13 successful checks
ci.nodejs.org status: one failure (centos6-64), one machine (freebsd10-64) still running (https://ci.nodejs.org/job/node-test-commit/14457/)
P.S. Now the status has suddenly turned into "1 pending and 12 successful checks".
P.P.S Now it is "All checks have passed. 13 successful checks" again, but we still have that one failure.
The text was updated successfully, but these errors were encountered: