Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Windows installer builds #1472

Closed
rvagg opened this issue Apr 20, 2015 · 3 comments
Closed

Broken Windows installer builds #1472

rvagg opened this issue Apr 20, 2015 · 3 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@rvagg
Copy link
Member

rvagg commented Apr 20, 2015

e.g. https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/150/nodes=iojs-win2008r2-release-ia32/console

c:\workspace\iojs+release+nightly\nodes\iojs-win2008r2-release-ia32\tools\msvs\msi\product.wxs(14): error CNDL0006: The Product/@Version attribute's value cannot be an empty string. If a value is not required, simply remove the entire attribute. [c:\workspace\iojs+release+nightly\nodes\iojs-win2008r2-release-ia32\tools\msvs\msi\nodemsi.wixproj]
c:\workspace\iojs+release+nightly\nodes\iojs-win2008r2-release-ia32\tools\msvs\msi\product.wxs(14): error CNDL0010: The Product/@Version attribute was not found; it is required. [c:\workspace\iojs+release+nightly\nodes\iojs-win2008r2-release-ia32\tools\msvs\msi\nodemsi.wixproj]

@jbergstroem, @chrisdickinson do you have any context for this? this is a new error.

@chrisdickinson
Copy link
Contributor

Yep, it's a result of the %PYTHON% change – The filename, directory name, or volume label syntax is incorrect. is a failure in this line.

@chrisdickinson
Copy link
Contributor

Once the OSX build box is back up, this PR can be merged and we can cut a v1.8.1 release. edit: that PR reverts the PYTHON env var change.

@brendanashworth brendanashworth added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Apr 20, 2015
@Fishrock123
Copy link
Contributor

Fixed in 53ed89d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants