Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

napi_get_value_string_latin1 not mentioned in N-API docs #14397

Closed
RReverser opened this issue Jul 20, 2017 · 2 comments
Closed

napi_get_value_string_latin1 not mentioned in N-API docs #14397

RReverser opened this issue Jul 20, 2017 · 2 comments
Assignees
@mhdawson
Labels
addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Comments

@RReverser
Copy link
Member

napi_get_value_string_latin1 was introduced in the implementation, but doesn't appear on the documentation page. cc @nodejs/n-api (relevant to #13556)
@RReverser RReverser added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jul 20, 2017
@mhdawson
Copy link
Member

Thanks, I'll take a look and add.

@kfarnung
Copy link
Contributor

kfarnung commented Aug 7, 2017

@RReverser @mhdawson I have a PR #14678 out for this issue.

@kfarnung kfarnung mentioned this issue Aug 7, 2017
Closed
2 tasks
MSLaguana pushed a commit to nodejs/node-chakracore that referenced this issue Aug 21, 2017
@kfarnung @MSLaguana
doc: added napi_get_value_string_latin1
57604d1 
* Reordered string functions alphabetically
* Fixed a typo in napi_get_value_string_utf8

PR-URL: nodejs/node#14678
Fixes: nodejs/node#14397
Refs: nodejs/node#14256
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 10, 2017
@kfarnung @MylesBorins
doc: added napi_get_value_string_latin1
2f87de9 
* Reordered string functions alphabetically
* Fixed a typo in napi_get_value_string_utf8

PR-URL: #14678
Fixes: #14397
Refs: #14256
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 12, 2017
@kfarnung @MylesBorins
doc: added napi_get_value_string_latin1
0dc9d28 
* Reordered string functions alphabetically
* Fixed a typo in napi_get_value_string_utf8

PR-URL: #14678
Fixes: #14397
Refs: #14256
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
@kfarnung
doc: added napi_get_value_string_latin1
b0abcbf 
* Reordered string functions alphabetically
* Fixed a typo in napi_get_value_string_utf8

PR-URL: nodejs#14678
Fixes: nodejs#14397
Refs: nodejs#14256
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 16, 2018
@kfarnung @MylesBorins
doc: added napi_get_value_string_latin1
b0f09a2 
* Reordered string functions alphabetically
* Fixed a typo in napi_get_value_string_utf8

Backport-PR-URL: #19447
PR-URL: #14678
Fixes: #14397
Refs: #14256
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhdawson mhdawson

Labels
addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: added napi_get_value_string_latin1 kfarnung/node
3 participants
@RReverser @kfarnung @mhdawson