Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Landing Pull Requests" is incompatible with repo setup in CONTRIBUTING.md #13600

Closed
seishun opened this issue Jun 10, 2017 · 1 comment · Fixed by #13602
Closed

"Landing Pull Requests" is incompatible with repo setup in CONTRIBUTING.md #13600

seishun opened this issue Jun 10, 2017 · 1 comment · Fixed by #13602
Labels
doc Issues and PRs related to the documentations.

Comments

@seishun
Copy link
Contributor

seishun commented Jun 10, 2017 •
edited
Loading

The "Technical HOWTO" section in COLLABORATOR_GUIDE.md "assumes your repo is set up as detailed in CONTRIBUTING.md".

However, the "Step 1: Fork" section in CONTRIBUTING.md suggests setting up upstream as git://github.com/nodejs/node.git. When trying to push to it, git returns the following error:

fatal: remote error:
  You can't push to git://github.com/nodejs/node.git
  Use https://github.com/nodejs/node.git

Is there a particular reason why CONTRIBUTING.md uses a git:// link? Can we just replace that with [email protected]:nodejs/node.git?
@seishun seishun added the doc Issues and PRs related to the documentations. label Jun 10, 2017
@refack
Copy link
Contributor

refack commented Jun 10, 2017 •
edited
Loading

GitHub recommends using the https urls, so IMHO CONTRIBUTING.md should use the https (we require 2FA from Collaboratos anyway)
Ref: https://help.github.com/articles/which-remote-url-should-i-use/

@seishun seishun mentioned this issue Jun 10, 2017
Merged
2 tasks
addaleax pushed a commit that referenced this issue Jun 12, 2017
@seishun @addaleax
doc: use HTTPS URL for suggested upstream remote
52f5e3f 
It's impossible to push to git:// URLs.

PR-URL: #13602
Fixes: #13600
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this issue Jul 17, 2017
@seishun @MylesBorins
doc: use HTTPS URL for suggested upstream remote
9fa7006 
It's impossible to push to git:// URLs.

PR-URL: #13602
Fixes: #13600
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: use HTTPS URL for suggested upstream remote
2 participants
@refack @seishun