Collaborator nominations

[jasnell]

Time to open another round of collaborator nominations.

• @jasongin

  • Most notable PR: module: add support for abi stable module API module: add support for abi stable module API #11975
  • Other NodeCore PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Ajasongin
  • Helped review/contributed to trace controller PR Trace event support for Node.js #9304
  • Creator and lead maintainer of cross-platform nvm like node version manager called Node Version Switcher (aka: nvs). Additional benefits of nvs include first class Windows support and support for Node-ChakraCore
  • Member of Node Version management WG : https://github.com/nodejs/version-management
  • https://github.com/nodejs/node/pulls/jasongin
  • https://github.com/nodejs/node/commits/master?author=jasongin
  • https://github.com/nodejs/abi-stable-node/commits/api-prototype-8.x?author=jasongin
  • https://github.com/nodejs/node-api/commits/master?author=jasongin

• @kunalspathak:

  • Most notable PR: Enable Node.js to run with Microsoft's ChakraCore engine Enable Node.js to run with Microsoft's ChakraCore engine #4765
  • Other NodeCore PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Akunalspathak
  • Member of Build WG Add Kunal Pathak to Build WG build#649
  • Added Win2016 support for Node CI libuv Windows CI: Windows server 2016 libuv/libuv#1245
  • https://github.com/nodejs/node/pulls/kunalspathak
  • https://github.com/nodejs/node/commits/master?author=kunalspathak
  • https://github.com/nodejs/node-chakracore/commits/chakracore-master?author=kunalspathak

[joshgav]

+1, Jason's work on N-API and Kunal's work on Windows and VS support in Node's build system have been really helpful contributions!

@jasnell: Fixed a couple links in the original post.

[mikeal]

Are there people that were committers in N-API before it was merged that aren't committers in Core? Maybe we should do some kind of bulk issue for all of them because it should be uncontroversial given the impact of that work.

[aruneshchandra]

@mikeal yes they are listed on the PR #11975

[mhdawson]

+1 from me on the 2 nominations.

[addaleax]

I’d like to nominate:

• @tniessen:
  • Most notable PR: crypto: add sign/verify support for RSASSA-PSS crypto: add sign/verify support for RSASSA-PSS #11705
  • Other NodeCore PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Atniessen
  • https://github.com/nodejs/node/pulls/tniessen
  • https://github.com/nodejs/node/commits/master?author=tniessen

[targos]

+1 to all 3 nominations.

[mhdawson]

I'd like to add

@gireeshpunathil

Pull requests: https://github.com/nodejs/node/pulls/gireeshpunathil
Issues commented on: https://github.com/issues?utf8=✓&q=repo%3Anodejs%2Fnode+is%3Aissue+commenter%3Agireeshpunathil

[mhdawson]

And +1 to all 4 nominations from me.

[gibfahn]

+1 (to all 4)

[sam-github]

+1 to all of them

[evanlucas]

+1 to all 4

[richardlau]

+1 to all 4 too

[Fishrock123]

@jasongin and @kunalspathak were added via #13200 (👏!)

[Trott]

I think the only person remaining to be onboarded in this issue is @gireeshpunathil. I'll send them an email and try to set something up.

[Trott]

In the meantime, I'd also like to nominate @XadillaX:

• issues and pull requests
• commits
• comments

[gibfahn]

+1 to @XadillaX

[mcollina]

I would like to nominate:

@bmeurer, for both his direct and indirect help on all V8 topics.

Comments: https://github.com/nodejs/node/search?q=commenter%3Abmeurer&type=Issues&utf8=%E2%9C%93
Commits: https://github.com/nodejs/node/commits?author=bmeurer

@sebdeckers, for his work on http2

Comments: https://github.com/nodejs/http2/search?q=commenter%3Asebdeckers&type=Issues&utf8=%E2%9C%93
Commits: https://github.com/nodejs/http2/commits/master?author=sebdeckers

@BridgeAR

Comments: https://github.com/nodejs/node/search?q=commenter%3ABridgeAR&type=Issues&utf8=%E2%9C%93
Commits: https://github.com/nodejs/node/commits/master?author=BridgeAR

[gibfahn]

Let's just take 👍 responses as +1s going forward. I assume that's what everyone else means by it.

[refack]

+1 for all three
And an extra personal +1 for @BridgeAR whom I've been working closely with and has been dominating the Pulse

[jasnell]

Big +1 to all three (@bmeurer, @sebdeckers and @BridgeAR).

I will say that @sebdeckers has provided some fantastic help with the http/2 work. Would love to see them get some recognition!

[addaleax]

I think it might be time for @gabrielschulhof as well?

Comments: https://github.com/nodejs/node/search?q=commenter%3Agabrielschulhof&type=Issues&utf8=%E2%9C%93
Commits: https://github.com/nodejs/node/commits/master?author=gabrielschulhof

[addaleax]

Also, is anybody (@Trott) actively scheduling onboarding sessions? I can do some after next week

[Trott]

Also, is anybody (@Trott) actively scheduling onboarding sessions? I can do some after next week

@addaleax I talked to @fhinkel and she was going to see if @bmeurer is interested or not. Other than that, I haven't been doing anything, but doing something has been on my list. Feel free to run with it! :-D

[jasongin]

I'd like to nominate @kfarnung

Kyle has been helpful for the last two months with both the N-API project and Node-ChakraCore.

Comments:
https://github.com/nodejs/node/search?utf8=%E2%9C%93&q=commenter%3Akfarnung&type=Issues
https://github.com/nodejs/node-addon-api/search?utf8=%E2%9C%93&q=commenter%3Akfarnung&type=Issues

Commits:
https://github.com/nodejs/node/commits/master?author=kfarnung
https://github.com/nodejs/node-addon-api/commits?author=kfarnung
https://github.com/nodejs/node-chakracore/commits/master?author=kfarnung

[mhdawson]

+1 for Gabriel he has made significant contributions on the N-API side.

[Trott]

+1 for Gabriel he has made significant contributions on the N-API side.

Gabriel's already done!

As of this remaining nominees to onboard:

• @bmeurer (will be onboarded by @fhinkel)
• @BridgeAR (will be onboarded by me in less than 24 hours)
• @sebdeckers (I was trying to set something up with them, not sure what happened, but will resume after @BridgeAR is onboarded)
• @kfarnung (pending CTC consensus)

[sebdeckers]

@Trott Apologies for the delayed response. Life got in the way. 🚧 Will answer your email to continue the process (if the opportunity has not yet lapsed?).

[jasnell]

The opportunity definitely hasn't lapsed! If @Trott is not able to find a time, I'll happily guide you through the steps.

[Trott]

Updating: Two left in this round:

• @bmeurer
• @kfarnung

[BridgeAR]

I would like to nominate @apapirovski. He has done a awesome job by improving the http2 module and more.

Comments: https://github.com/nodejs/node/search?q=commenter%3Aapapirovski&type=Issues&utf8=%E2%9C%93
Commits: https://github.com/nodejs/node/commits/master?author=apapirovski
PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Aapapirovski

[mhdawson]

+1 for @apapirovski

[refack]

For context, who should nominate new Collaborators? The GOVERNANCE doc state that it's the TSC's responsibility to identify and add new Collaborators, but AFAICT anyone should be able to soft nominate...

The nodejs/node GitHub repository is maintained by Collaborators who are added by the TSC on an ongoing basis.

Individuals identified by the TSC as making significant and valuable contributions across any Node.js repository may be made Collaborators and given commit access to the project.

[mcollina]

It should be the TSC.

I nominate @apapirovski. I have been lagging behind, it was on my todo list :/.

[BridgeAR]

As far as I read the mentioned text, it does not exclude anyone from nominating someone - even if that might have been the original intention. The only clear stated thing there is, is that the TSC has to agree that the nominated person has done a significant and valuable contribution to Node.js.
I also read the text in the TSC repo about nominating new members and it is inconclusive due to not stating if it is about the TSC members or any members. I expect it to be about the TSC members as it is only written down in that repo.

As further info: I asked two persons from the TSC before doing this and both told me to just nominate the person on my own.

[Trott]

My understanding has always been that anyone can suggest, but TSC must approve (even if only tacitly).

Part of the confusion here might be due to the ambiguity of the term nominate. That could mean "suggest" or it could refer to a more official nomination process. So I avoided the word in the first sentence/paragraph above.

[jasnell]

+1 to @apapirovski !

[tniessen]

In my opinion we should restrict this discussion to official nominations by TSC members. Anyone can suggest, but I think it is a good idea to do so in private (as @BridgeAR did), mainly to prevent people from feeling let down after being suggested publically on GitHub without being considered a nominee afterwards.

[gibfahn]

to prevent people from feeling let down after being suggested publically on GitHub without being considered a nominee afterwards.

But that could still happen even if nominated by a TSC member.

[addaleax]

@gibfahn We sometimes (usually? this isn’t a very well-defined process and we’ve switched around a bit over the last year, I think) ask for objections on the TSC email list before public nominations, so there is a bit of a difference :)

[gibfahn]

Ahh okay, so they're basically already approved before being added here. Didn't realise that. Maybe just make that the default then, suggested privately by a TSC member (to make sure there are no objections there), then suggested publically here (to make sure there are no strenuous objections from collaborators).

In that case TSC suggesting only makes sense (obviously if a collaborator wants to suggest someone they can talk to their friendly neighbourhood TSC member).

[jasnell]

Some of the time it's done by TSC email first, but not always. To be honest, I prefer nominations to be public and if someone wants to raise an objection then that should be public too along with a reasonable explanation. In general, our process should be biased towards approving nominations from anyone who has made a concrete contribution.

[Trott]

Just to keep things up to date:

• I've got an onboarding session scheduled with @bmeurer already.
• Once that's all done, I'll schedule one with @kfarnung if they're interested.
• And after that gets sorted, on to @apapirovski.

If anyone on the TSC wants to onboard either of those last two, no need to wait for me. (I mean, that is hopefully obvious, but just in case it's not: Book it and do it.)

[kfarnung]

I'm definitely still interested, but no rush. When people have time I'll be available.

[Trott]

Both bmeurer and kfarnung are now Collaborators. 🎉

Now to schedule something with @apapirovski!

[apapirovski]

@Trott email is in my profile. I'm generally pretty available and flexible. No rush :)

[fhinkel]

I would like to nominate @hashseed because of his V8 expertise. Here are his commits.

[hashseed]

Thanks for the nomination. I'd be honored to become a collaborator!

[targos]

I would like to nominate @guybedford. He has been extremely helpful with the implementation and maintenance of ESM.

Comments: https://github.com/nodejs/node/search?q=commenter%3Aguybedford&type=Issues&utf8=%E2%9C%93
Commits: https://github.com/nodejs/node/commits/master?author=guybedford
PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Aguybedford

[evanlucas]

+1 to @hashseed and @guybedford

[mcollina]

👍 for both @hashseed and @guybedford.

[mhdawson]

+1 to @hashseed and @guybedford

[joyeecheung]

I would like to nominate @maclover7 (thought they was a collaborator until I noticed not, we will get onboard into the build WG together tomorrow)

Commits in core
Issues/PRs in core
Issues/PRs in build

[cjihrig]

+1 to @hashseed @guybedford and @maclover7

[mhdawson]

+1 to maclover7 as well.

[maclover7]

Thank you @joyeecheung -- I'd love to join the team :)

[evanlucas]

+1 to @maclover7 too

[Trott]

Everyone nominated in this issue has been onboarded! I'm closing this issue. It's always good to have more nominations, so if you've got someone to nominate, open a new issue! Thanks!