-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What are Node.js "Linked" modules? #12516
Comments
It's probably this in the build script:
|
@mscdex That’s something different. The linked modules the C++ source is talking about would be native modules that are compiled into (or |
Well, that's not confusing ;-) |
The configure switch is for baking third-party JS source code into the binary, NM_F_LINKED is for bundling add-ons into the binary. Unfortunate name clash, yes. |
@bnoordhuis Is there anybody who uses that feature? Would documenting it be a good idea? |
I assume so, at least at the time, otherwise why bother making a pull request? Both features where requested and implemented by non-collaborators. Documenting it: no reason not to, I suppose. |
Hi I'd like to work on this. This is my first time working on open source and I was wondering which part of the documentation this should go into, and generally the relevant parts of the source I should be looking at. |
I guess it should go somewhere in https://nodejs.org/api/modules.html (source here)? As mentioned above, for the Native module you probably want to start here: Lines 2595 to 2599 in 4359a93
For the js module you probably want to start here: Lines 152 to 158 in 201ecef
@bnoordhuis are the two features functionally identical, except for the fact that one is for native addons and one is for js addons? |
Awesome, thanks for the tips @gibfahn I'll look into it. |
Fixes: #12516 Refs: #2497 PR-URL: #17705 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #12516 Refs: #2497 PR-URL: #17705 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #12516 Refs: #2497 PR-URL: #17705 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #12516 Refs: #2497 PR-URL: #17705 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Reopen since the OP is asking about native modules and they are still not documented. Should be fixed by #19112 |
Sounds like this was addressed by @joyeecheung above. Closing. |
Fixes: nodejs#12516 Refs: nodejs#2497 PR-URL: nodejs#17705 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
When I was going through the source code, I found this in node.cc,
Does anybody know what "Linked" modules are? @bnoordhuis maybe?
cc @addaleax
The text was updated successfully, but these errors were encountered: