new lint option on windows is missing documentation #11971
Comments
refack
changed the title
gibfahn
added
the
good first issue
|
This seems like a good first contribution for someone (@refack if you want to fix it yourself feel free). |
|
Not first! 😛 |
@refack not sure what you mean. If you're intending to fix it yourself then go for it, I assumed you weren't planning to, normally people don't bother to raise an Issue first if it's a simple PR. |
|
I might, but why do you assume it'll be my first contribution 😉
Also I believe even a post-mortem code review helps the original author...
…On Tue, Mar 21, 2017 at 1:40 PM, Gibson Fahnestock ***@***.*** > wrote:
Not first!
@refack <https://github.com/refack> not sure what you mean. If you're
intending to fix it yourself then go for it, I assumed you weren't planning
to, as normally people don't bother to raise Issues if it's a simple PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11971 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAF6s0wHzxgR0RAFNHfrhnNvAgF_j4-Oks5roAt9gaJpZM4MkILV>
.
|
|
Ohh, did you mean you wanted to? Sorry 😬. Go ahead! I'm working on something else... |
|
@refack I assumed you weren't planning to raise a PR yourself, so added the tag to open it up to anybody. If you're going to fix it then great, please do!
Agreed, not saying you shouldn't raise an issue, just that most people wouldn't bother. And yeah, I'm following the |
|
I'll give this a go as a first contribution. |
PR-URL: #11992 Fixes: #11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#11992 Fixes: nodejs#11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
180bec1 PR-URL: #11992 Fixes: #11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
#11856 (review)
/cc @liusy182
New options should be documented in
helpline (now 420) ofvcbuild.batThe text was updated successfully, but these errors were encountered: