-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple test failures in 7.7.0 #11627
Comments
Perhaps this commit can help? It's not in v7.x because it was part of a semver-major V8 upgrade. |
It fixes the first failure, but the later two crashes are still present. |
/cc @nodejs/diagnostics and @fhinkel for the crashes. |
How exactly are you building node (configure flags, toolchain)? Do the official binaries from nodejs.org work? |
configure flags:
|
Does a |
I can reproduce these failures… looking into it (Edit: Didn’t see Ben’s comment. Just |
Seems like this would be fixed by #11634, too (which makes sense to me). I have no idea how that got through our CI, though. |
@italoacasas I think you can cherry-pick ca48071 into 7.7.1 too, as pointed out above by @targos |
test-intl-no-icu-data fails in a different way in the 7.7.1 release:
|
@felixonmars do you know if |
Yes, it is present in current |
The problem is caused by the |
/cc @nodejs/intl |
See the discussion in nodejs/build#419, we currently don't test shared builds. Until that is done support is self-serve and things like test failures will keep popping up. A pull request that makes the test pass with both types of builds is welcome. |
I am building node for Arch Linux. The following test failures are new in 7.7.0:
The text was updated successfully, but these errors were encountered: