Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include $DOCS_ANALYTICS when building docs #11050

Closed
phillipj opened this issue Jan 28, 2017 · 6 comments
Closed

Include $DOCS_ANALYTICS when building docs #11050

phillipj opened this issue Jan 28, 2017 · 6 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@phillipj
Copy link
Member

phillipj commented Jan 28, 2017

Subsystem: docs

I'm following up #6601 which enables Google Analytics tracking on docs pages.

For the tracking code to be included, $DOCS_ANALYTICS needs to be set when running make doc. I've been having trouble finding who or where docs are generated when a new release is made, so I don't really know who to ping.

Found the Node.js release guide wiki page which has a section named Publish API docs, but it seems outdated the website-upload make target doesn't exist anymore.

@evanlucas
Copy link
Contributor

@phillipj We currently follow https://github.com/nodejs/node/blob/master/doc/releases.md when cutting releases. I'm pretty sure there is some magic on in ci-release that actually pushes the api docs though. /cc @rvagg or @jbergstroem?

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jan 28, 2017
@phillipj
Copy link
Member Author

@mikeal what should the Google Analytics ID be for docs?

@phillipj
Copy link
Member Author

@mikeal please confirm the GA ID UA-67020396-1.

Found it in your initial shot a GA trackings in docs (#6462), which also looks to be the same as we use on www.nodejs.org.

@phillipj
Copy link
Member Author

@rvagg are docs generated somewhere in CI when cutting releases?

@phillipj
Copy link
Member Author

@rvagg ping ^

@phillipj
Copy link
Member Author

Closing this for now as @rvagg just added $DOCS_ANALYTICS as requested.

Refs nodejs/nodejs.org#1268 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

No branches or pull requests

3 participants