Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default secure context is not created with options passed to TLSSocket constructor #10643

Closed
jkryl opened this issue Jan 5, 2017 · 2 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. tls Issues and PRs related to the tls subsystem.

Comments

@jkryl
Copy link

jkryl commented Jan 5, 2017

  • Version: v4.6.1
  • Platform: SunOS
  • Subsystem: tls

Spotted on 4.6.1 but seems to be the case even with the latest node version.
Documentation for TLSSocket() says that if secureContext is not specified it is created passing the same options as to TLSSocket constructor:

https://nodejs.org/api/tls.html#tls_class_tls_tlssocket

but looking at the code it is not true:

https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L351

secureContext is created without any options. I found it out by passing key and cert options to TLSSocket() which were simply ignored.

@addaleax
Copy link
Member

addaleax commented Jan 5, 2017

Is this the same as #10538? If so, please also see the discussion at #10545

@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Jan 5, 2017
@addaleax
Copy link
Member

addaleax commented Jan 5, 2017

Looking at the other issue it seems like this one is a dupliucate, too. So the same goes here, please ask any questions you may have on the existing thread(s). :)

@addaleax addaleax closed this as completed Jan 5, 2017
@addaleax addaleax added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants