-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing npm 4 into node 7 #10505
Comments
I'm 👍 after npm4 has had a chance to sit in master for a couple of weeks. |
@thealphanerd You mean partial shrinkwraps — the ones that don't correspond to the fully resolved dependency tree for the specified versions? |
As stated in a previous CTC meeting, I think this will be our best shot to gauge how many people may be impacted by npm changes from core. We have like no data and this is minimal enough that I think we should probably do it, if only for the sake of gathering a sort of data. (Although coordination with @nodejs/npm will be necessary given that reports may end up on the npm issue tracker rather than ours.) |
Closing since this already landed in v7.4.0 |
If you want to support landing this please react with emojis to this post rather than posting your support in this thread, thank you
npm v4 just landed into master in 9946519
The CTC has discussed landing npm 4 into node 7 and so far all discussion has been positive. One of the biggest reasons is to get the deprecation warnings around
prepublish
into as many hands as possible to avoid confusion if npm 5 ships with node 8The only hesitation so far has been the dropping of support of partial shrinkwraps.
This did at one point break hapi, but was fixed in hapijs/hapi@0ca8cea (thanks for pointing that out @iarna). It is worth mentioning that this will likely break older hapi builds on npm4 if the change was not backported.
It might be a good idea to scan the registry and find out what other projects are currently shipping broken shrinkwraps so we can better estimate ecosystem brekages, /cc @ChALkeR.
Please chime in if you have any concerns, we can bring this to the ctc again next week.
/cc @nodejs/npm
The text was updated successfully, but these errors were encountered: