Skip to content

Commit

Permalink
test: revoke flaky designation for tests
Browse files Browse the repository at this point in the history
A number of tests that were `flaked` recently are proved
to have failing reason identified in
#25007 and resolution
identified in #25061

Revoke flaky designation of all these tests as the said
PR is landed.

PR-URL: #25611
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
  • Loading branch information
gireeshpunathil authored and MylesBorins committed May 16, 2019
1 parent 554b562 commit fbf8e60
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
8 changes: 0 additions & 8 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,8 @@ prefix parallel
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/25029
test-child-process-execfile: PASS,FLAKY
# https://github.com/nodejs/node/issues/23207
test-net-connect-options-port: PASS,FLAKY
# https://github.com/nodejs/node/issues/25033
test-child-process-exit-code: PASS,FLAKY
# https://github.com/nodejs/node/issues/24305
test-trace-events-api-worker-disabled: PASS,FLAKY

Expand All @@ -36,7 +32,3 @@ test-worker-prof: PASS,FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/issues/25029
test-child-process-execfile: PASS,FLAKY
# https://github.com/nodejs/node/issues/25068
test-util-callbackify: PASS,FLAKY
9 changes: 0 additions & 9 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ prefix sequential
[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/22336
test-gc-http-client: PASS,FLAKY
# https://github.com/nodejs/node/issues/24403
test-cli-syntax-bad: PASS,FLAKY
test-cli-syntax-file-not-found: PASS,FLAKY
test-cli-syntax-good: PASS,FLAKY
test-cli-syntax-require: PASS,FLAKY

[$system==win32]
# https://github.com/nodejs/node/issues/22327
Expand All @@ -26,9 +21,5 @@ test-http2-large-file: PASS, FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/issues/24921
test-child-process-execsync: PASS, FLAKY
# https://github.com/nodejs/node/issues/25047
test-inspector-debug-end: PASS, FLAKY

[$arch==arm]

0 comments on commit fbf8e60

Please sign in to comment.