test: improve crypto test coverage

- Call Sign without new - Call Verify without new - Call Verify#verify with options.padding !== options.padding >> 0 - Call Verify#verify with options.saltLength !== options.saltLength >> 0 PR-URL: #17426 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Dec 12, 2017 · fb553b5 · fb553b5
1 parent 928aecc
commit fb553b5
Showing 1 changed file with 36 additions and 0 deletions.
diff --git a/test/parallel/test-crypto-sign-verify.js b/test/parallel/test-crypto-sign-verify.js
@@ -15,6 +15,42 @@ const certPem = fixtures.readSync('test_cert.pem', 'ascii');
 const keyPem = fixtures.readSync('test_key.pem', 'ascii');
 const modSize = 1024;
 
+{
+  const Sign = crypto.Sign;
+  const instance = Sign('SHA256');
+  assert(instance instanceof Sign, 'Sign is expected to return a new ' +
+                                   'instance when called without `new`');
+}
+
+{
+  const Verify = crypto.Verify;
+  const instance = Verify('SHA256');
+  assert(instance instanceof Verify, 'Verify is expected to return a new ' +
+                                     'instance when called without `new`');
+}
+
+common.expectsError(
+  () => crypto.createVerify('SHA256').verify({
+    key: certPem,
+    padding: undefined,
+  }, ''),
+  {
+    code: 'ERR_INVALID_OPT_VALUE',
+    type: Error,
+    message: 'The value "undefined" is invalid for option "padding"'
+  });
+
+common.expectsError(
+  () => crypto.createVerify('SHA256').verify({
+    key: certPem,
+    saltLength: undefined,
+  }, ''),
+  {
+    code: 'ERR_INVALID_OPT_VALUE',
+    type: Error,
+    message: 'The value "undefined" is invalid for option "saltLength"'
+  });
+
 // Test signing and verifying
 {
   const s1 = crypto.createSign('SHA1')