assert: fix strict regression

Using `assert()` or `assert.ok()` resulted in a error since a refactoring. Refs: #17582 Backport-PR-URL: #19230 PR-URL: #17903 Refs: #17582 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 20, 2018 · f96ea47 · f96ea47
1 parent ebd60fa
commit f96ea47
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/assert.js b/lib/assert.js
@@ -319,7 +319,15 @@ assert.ifError = function ifError(err) { if (err) throw err; };
 
 // Expose a strict only variant of assert
 function strict(value, message) {
-  if (!value) innerFail(value, true, message, '==', strict);
+  if (!value) {
+    innerFail({
+      actual: value,
+      expected: true,
+      message,
+      operator: '==',
+      stackStartFn: strict
+    });
+  }
 }
 assert.strict = Object.assign(strict, assert, {
   equal: assert.strictEqual,

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -753,6 +753,14 @@ common.expectsError(
   assert.equal(Object.keys(assert).length, Object.keys(a).length);
   /* eslint-enable no-restricted-properties */
   assert(7);
+  common.expectsError(
+    () => assert(),
+    {
+      code: 'ERR_ASSERTION',
+      type: assert.AssertionError,
+      message: 'undefined == true'
+    }
+  );
 }
 
 common.expectsError(