test: use JSON.stringify to trigger stack overflow

V8's interpreter performs stack checks both at the call site and at the function entry. A recursive function could therefore trigger stack overflow at two different source locations. Instead of recursion, call JSON.stringify on a deeply nested array. PR-URL: #12481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · May 2, 2017 · f84a5e1 · f84a5e1
1 parent e77f1e2
commit f84a5e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/test/message/stack_overflow.js b/test/message/stack_overflow.js
@@ -5,10 +5,12 @@ Error.stackTraceLimit = 0;
 
 console.error('before');
 
-// stack overflow
-function stackOverflow() {
-  stackOverflow();
+// Trigger stack overflow by stringifying a deeply nested array.
+let array = [];
+for (let i = 0; i < 100000; i++) {
+  array = [ array ];
 }
-stackOverflow();
+
+JSON.stringify(array);
 
 console.error('after');
diff --git a/test/message/stack_overflow.out b/test/message/stack_overflow.out
@@ -1,6 +1,6 @@
 before
-
 *test*message*stack_overflow.js:*
-function stackOverflow() {
-                      ^
+JSON.stringify(array);
+     ^
+
 RangeError: Maximum call stack size exceeded