lib: replace Symbol.hasInstance by SymbolHasInstance

PR-URL: #30948 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 17, 2019 · f51b5bd · f51b5bd
1 parent 92475e9
commit f51b5bd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
@@ -30,6 +30,7 @@ const {
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
   Symbol,
+  SymbolHasInstance,
 } = primordials;
 
 module.exports = Writable;
@@ -203,9 +204,9 @@ ObjectDefineProperty(WritableState.prototype, 'buffer', {
 // Test _writableState for inheritance to account for Duplex streams,
 // whose prototype chain only points to Readable.
 var realHasInstance;
-if (typeof Symbol === 'function' && Symbol.hasInstance) {
-  realHasInstance = Function.prototype[Symbol.hasInstance];
-  ObjectDefineProperty(Writable, Symbol.hasInstance, {
+if (typeof Symbol === 'function' && SymbolHasInstance) {
+  realHasInstance = Function.prototype[SymbolHasInstance];
+  ObjectDefineProperty(Writable, SymbolHasInstance, {
     value: function(object) {
       if (realHasInstance.call(this, object))
         return true;

diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -16,6 +16,7 @@ const {
   ObjectValues,
   ReflectOwnKeys,
   Symbol,
+  SymbolHasInstance,
 } = primordials;
 
 const { trace } = internalBinding('trace_events');
@@ -133,7 +134,7 @@ const consolePropAttributes = {
 };
 
 // Fixup global.console instanceof global.console.Console
-ObjectDefineProperty(Console, Symbol.hasInstance, {
+ObjectDefineProperty(Console, SymbolHasInstance, {
   value(instance) {
     return instance[kIsConsole];
   }