From f408d78914fe1b4151915f59c91cccb06d8436d8 Mon Sep 17 00:00:00 2001 From: Thang Tran Date: Wed, 6 Feb 2019 02:58:43 +0100 Subject: [PATCH] build: fixed clang's warning when building openssl clang doesn't seem to support 'Wno-old-style-declaration', this is a work-around. Fixes: https://github.com/nodejs/node/issues/25550 Refs: https://github.com/nodejs/node-v0.x-archive/issues/4186 PR-URL: https://github.com/nodejs/node/pull/25954 Reviewed-By: Refael Ackermann Reviewed-By: Daniel Bevenius Reviewed-By: Richard Lau Reviewed-By: James M Snell --- deps/openssl/openssl_common.gypi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/deps/openssl/openssl_common.gypi b/deps/openssl/openssl_common.gypi index 75002e87c2690f..c4b95c20aea5d4 100644 --- a/deps/openssl/openssl_common.gypi +++ b/deps/openssl/openssl_common.gypi @@ -57,14 +57,17 @@ ], }, { # linux and others - 'cflags': ['-Wno-missing-field-initializers', - ## TODO: check gcc_version>=4.3 - '-Wno-old-style-declaration'], + 'cflags': ['-Wno-missing-field-initializers',], 'defines': [ 'OPENSSLDIR="/etc/ssl"', 'ENGINESDIR="/dev/null"', 'TERMIOS', ], + 'conditions': [ + [ 'llvm_version==0', { + 'cflags': ['-Wno-old-style-declaration',], + }], + ], }], ] }