Skip to content

Commit

Permalink
deps: V8: cherry-pick 716875d
Browse files Browse the repository at this point in the history
Original commit message:

    [build] Add message-template.h to build file

    This was missed during a file move and can cause build bugs.

    Bug: chromium:991547
    Change-Id: I157e7bb656956c08293c205c0d00884aecc7adee
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798430
    Commit-Queue: Sigurd Schneider <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Auto-Submit: Peter Marshall <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#63711}

Refs: v8/v8@716875d

Backport-PR-URL: #30109
PR-URL: #29694
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
  • Loading branch information
MylesBorins committed Jan 8, 2020
1 parent 43c5b91 commit f364b50
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.12',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2150,6 +2150,7 @@ v8_source_set("v8_base_without_compiler") {
"src/common/assert-scope.cc",
"src/common/assert-scope.h",
"src/common/checks.h",
"src/common/message-template.h",
"src/common/ptr-compr-inl.h",
"src/common/ptr-compr.h",
"src/compiler-dispatcher/compiler-dispatcher.cc",
Expand Down Expand Up @@ -2222,7 +2223,6 @@ v8_source_set("v8_base_without_compiler") {
"src/execution/isolate-utils.h",
"src/execution/isolate.cc",
"src/execution/isolate.h",
"src/execution/message-template.h",
"src/execution/messages.cc",
"src/execution/messages.h",
"src/execution/microtask-queue.cc",
Expand Down

0 comments on commit f364b50

Please sign in to comment.