crypto: move _impl call out of handleError funct

This commit moves the _impl function call out of the handleError function, which now only takes in an object as its parameter. PR-URL: #28318 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 2, 2019 · f21ddb2 · f21ddb2
1 parent 558e9cf
commit f21ddb2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/internal/crypto/keygen.js b/lib/internal/crypto/keygen.js
@@ -60,7 +60,7 @@ function generateKeyPair(type, options, callback) {
     callback.call(wrap, null, pubkey, privkey);
   };
 
-  handleError(impl, wrap);
+  handleError(impl(wrap));
 }
 
 Object.defineProperty(generateKeyPair, customPromisifyArgs, {
@@ -70,11 +70,10 @@ Object.defineProperty(generateKeyPair, customPromisifyArgs, {
 
 function generateKeyPairSync(type, options) {
   const impl = check(type, options);
-  return handleError(impl);
+  return handleError(impl());
 }
 
-function handleError(impl, wrap) {
-  const ret = impl(wrap);
+function handleError(ret) {
   if (ret === undefined)
     return; // async