-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: http2 compat response.write() error checks
PR-URL: #18859 Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
2 changed files
with
52 additions
and
95 deletions.
There are no files selected for viewing
95 changes: 0 additions & 95 deletions
95
test/parallel/test-http2-compat-serverresponse-write-no-cb.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
'use strict'; | ||
|
||
const { | ||
mustCall, | ||
mustNotCall, | ||
expectsError, | ||
hasCrypto, | ||
skip | ||
} = require('../common'); | ||
if (!hasCrypto) | ||
skip('missing crypto'); | ||
const { createServer, connect } = require('http2'); | ||
const assert = require('assert'); | ||
|
||
const server = createServer(); | ||
server.listen(0, mustCall(() => { | ||
const port = server.address().port; | ||
const url = `http://localhost:${port}`; | ||
const client = connect(url, mustCall(() => { | ||
const request = client.request(); | ||
request.resume(); | ||
request.on('end', mustCall()); | ||
request.on('close', mustCall(() => { | ||
client.close(); | ||
})); | ||
})); | ||
|
||
server.once('request', mustCall((request, response) => { | ||
// response.write() returns true | ||
assert(response.write('muahaha', 'utf8', mustCall())); | ||
|
||
response.stream.close(0, mustCall(() => { | ||
response.on('error', mustNotCall()); | ||
|
||
// response.write() without cb returns error | ||
expectsError( | ||
() => { response.write('muahaha'); }, | ||
{ | ||
type: Error, | ||
code: 'ERR_HTTP2_INVALID_STREAM', | ||
message: 'The stream has been destroyed' | ||
} | ||
); | ||
|
||
// response.write() with cb returns falsy value | ||
assert(!response.write('muahaha', mustCall())); | ||
|
||
client.destroy(); | ||
server.close(); | ||
})); | ||
})); | ||
})); |