assert: handle undefined filename in getErrMessage

When generating an assertion error message, `filename` might be undefined, e.g. if `assert` is called in `eval`. Handle this case gracefully instead of failing with `Cannot read property 'endsWith' of undefined`. Fixes: #20847 PR-URL: #20848 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · May 25, 2018 · ea702e2 · ea702e2
1 parent ed9e964
commit ea702e2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -153,6 +153,10 @@ function getBuffer(fd, assertLine) {
 
 function getErrMessage(call) {
   const filename = call.getFileName();
+  if (!filename) {
+    return;
+  }
+
   const line = call.getLineNumber() - 1;
   const column = call.getColumnNumber() - 1;
   const identifier = `${filename}${line}${column}`;

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -783,6 +783,16 @@ common.expectsError(
   }
 );
 
+// works in eval
+common.expectsError(
+  () => new Function('assert', 'assert(1 === 2);')(assert),
+  {
+    code: 'ERR_ASSERTION',
+    type: assert.AssertionError,
+    message: 'false == true'
+  }
+);
+
 // Do not try to check Node.js modules.
 {
   const e = new EventEmitter();