Skip to content

Commit

Permalink
deps: add no-strict-aliasing to ICU cflags
Browse files Browse the repository at this point in the history
This commit adds -Wno-strict-aliasing to the icu_implementation target.
The motivation for this is that this flags is enabled when building with
macosx, and will make the output a little cleaner when building on
other operating systems.

PR-URL: #23112
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
danbev authored and targos committed Oct 5, 2018
1 parent 2b8f569 commit e93c94c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/icu/icu-generic.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
'direct_dependent_settings': {
'conditions': [
[ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
'cflags': [ '-Wno-deprecated-declarations' ],
'cflags': [ '-Wno-deprecated-declarations', '-Wno-strict-aliasing' ],
'cflags_cc': [ '-frtti' ],
'cflags_cc!': [ '-fno-rtti' ],
}],
Expand Down

0 comments on commit e93c94c

Please sign in to comment.