http2: override authority with options

Make `options.host` and `options.port` take precedence over `authority.host` and `authority.port` respectively. PR-URL: #28584 Fixes: #28182 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Jul 10, 2019 · e800f9d · e800f9d
1 parent fe4d53d
commit e800f9d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -2795,7 +2795,7 @@ function connect(authority, options, listener) {
   } else {
     switch (protocol) {
       case 'http:':
-        socket = net.connect(port, host);
+        socket = net.connect(options.port || port, options.host || host);
         break;
       case 'https:':
         socket = tls.connect(port, host, initializeTLSOptions(options, host));

diff --git a/test/parallel/test-http2-connect.js b/test/parallel/test-http2-connect.js
@@ -101,3 +101,18 @@ if (hasIPv6) {
     }
   }));
 }
+
+// Check that `options.host` and `options.port` take precedence over
+// `authority.host` and `authority.port`.
+{
+  const server = createServer();
+  server.listen(0, mustCall(() => {
+    connect('http://foo.bar', {
+      host: 'localhost',
+      port: server.address().port
+    }, mustCall((session) => {
+      session.close();
+      server.close();
+    }));
+  }));
+}