repl: use promise#finally

PR-URL: #23971 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Nov 29, 2018 · e5177e9 · e5177e9
1 parent 06844e8
commit e5177e9
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -374,25 +374,19 @@ function REPLServer(prompt,
         }
 
         promise.then((result) => {
-          // Remove prioritized SIGINT listener if it was not called.
-          // TODO(TimothyGu): Use Promise.prototype.finally when it becomes
-          // available.
-          prioritizedSigintQueue.delete(sigintListener);
-
           finishExecution(undefined, result);
-          unpause();
         }, (err) => {
-          // Remove prioritized SIGINT listener if it was not called.
-          prioritizedSigintQueue.delete(sigintListener);
-
-          unpause();
           if (err && process.domain) {
             debug('not recoverable, send to domain');
             process.domain.emit('error', err);
             process.domain.exit();
             return;
           }
           finishExecution(err);
+        }).finally(() => {
+          // Remove prioritized SIGINT listener if it was not called.
+          prioritizedSigintQueue.delete(sigintListener);
+          unpause();
         });
       }
     }