tools,gyp: don't force build actions with multiple outputs

Don't add `force_append` (FORCE_DO_CMD) to the intermediate sentinal. Adding it makes the action run alway, even when there are no changes. (refack): AFAICT because `*.intermediate` files don't have build rules. PR-URL: #23156 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Oct 3, 2018 · d8cedf5 · d8cedf5
1 parent 180099a
commit d8cedf5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/tools/gyp/pylib/gyp/generator/make.py b/tools/gyp/pylib/gyp/generator/make.py
@@ -1758,8 +1758,10 @@ def WriteMakeRule(self, outputs, inputs, actions=None, comment=None,
       self.WriteLn('%s: %s' % (' '.join(outputs), intermediate))
       self.WriteLn('\t%s' % '@:');
       self.WriteLn('%s: %s' % ('.INTERMEDIATE', intermediate))
-      self.WriteLn('%s: %s%s' %
-                   (intermediate, ' '.join(inputs), force_append))
+      # Don't add `force_append` (FORCE_DO_CMD) to the intermediate sentinal.
+      # Adding it makes the action run alway, even when there are no changes.
+      # (refack): AFAICT because `*.intermediate` files don't have build rules.
+      self.WriteLn('%s: %s' % (intermediate, ' '.join(inputs)))
       actions.insert(0, '$(call do_cmd,touch)')
 
     if actions: