util: improve isInsideNodeModules

PR-URL: #52147 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jun 17, 2024 · d7eba50 · d7eba50
1 parent 918962d
commit d7eba50
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -35,6 +35,7 @@ const {
   SafeSet,
   SafeWeakMap,
   SafeWeakRef,
+  StringPrototypeIncludes,
   StringPrototypeReplace,
   StringPrototypeToLowerCase,
   StringPrototypeToUpperCase,
@@ -473,7 +474,7 @@ function spliceOne(list, index) {
   list.pop();
 }
 
-const kNodeModulesRE = /^(.*)[\\/]node_modules[\\/]/;
+const kNodeModulesRE = /^(?:.*)[\\/]node_modules[\\/]/;
 
 let getStructuredStack;
 
@@ -503,8 +504,12 @@ function isInsideNodeModules() {
       const filename = frame.getFileName();
       // If a filename does not start with / or contain \,
       // it's likely from Node.js core.
-      if (RegExpPrototypeExec(/^\/|\\/, filename) === null)
+      if (
+        filename[0] !== '/' &&
+        StringPrototypeIncludes(filename, '\\') === false
+      ) {
         continue;
+      }
       return RegExpPrototypeExec(kNodeModulesRE, filename) !== null;
     }
   }