From d6bc3117c63d936dd39b95a7a8dc984d3dba4beb Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Fri, 15 Jul 2022 15:54:15 -0300 Subject: [PATCH] doc: mention Win 32-bit openssl build issue PR-URL: https://github.com/nodejs/node/pull/43853 Reviewed-By: Richard Lau Reviewed-By: Antoine du Hamel --- doc/contributing/maintaining-openssl.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/doc/contributing/maintaining-openssl.md b/doc/contributing/maintaining-openssl.md index abcf055af57492..0c3b38840fdf4d 100644 --- a/doc/contributing/maintaining-openssl.md +++ b/doc/contributing/maintaining-openssl.md @@ -103,6 +103,16 @@ Use `make` to regenerate all platform dependent files in % make -C deps/openssl/config ``` +**Note**: If the 32-bit Windows is failing to compile run this workflow instead: + +```console +% make -C deps/openssl/config clean +# Edit deps/openssl/openssl/crypto/perlasm/x86asm.pl changing +# #ifdef to %ifdef to make it compatible to nasm on 32-bit Windows. +# See: https://github.com/nodejs/node/pull/43603#issuecomment-1170670844 +# Reference: https://github.com/openssl/openssl/issues/18459 +``` + ## 3. Check diffs Check diffs to ensure updates are right. Even if there are no updates in openssl