From d641164d091d0116d5fa34082d7a46d915beac7c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 4 Apr 2017 10:26:34 -0700 Subject: [PATCH] doc: update pull request template URL layout Putting the link for the commit guideline at the bottom of the pull request template makes it a bit confusing when opening a pull request as the markdown does not render. Not everyone is familiar with the syntax used there and it is easy to mess it up (for example, by not leaving a blank line above it). It is more natural and useful if the URL is included inline. PR-URL: https://github.com/nodejs/node/pull/12216 Reviewed-By: Gibson Fahnestock Reviewed-By: Vse Mozhet Byt Reviewed-By: Sam Roberts Reviewed-By: James M Snell Reviewed-By: Yuta Hiroto Reviewed-By: Richard Lau Reviewed-By: Timothy Gu Reviewed-By: Colin Ihrig --- .github/PULL_REQUEST_TEMPLATE.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 24b66f8b2f8b4d..8b133a64e09d68 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,9 +13,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md - [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added -- [ ] commit message follows [commit guidelines][] +- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines) ##### Affected core subsystem(s) - -[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines