From d4c04e05f7b1ef90365735f63a08d38a7d889550 Mon Sep 17 00:00:00 2001 From: Paul Blanche Date: Mon, 6 Nov 2017 16:27:05 +0100 Subject: [PATCH] test: improve assert messages in napi exception test Include unexpected value in assertion messages. Backport-PR-URL: https://github.com/nodejs/node/pull/19447 PR-URL: https://github.com/nodejs/node/pull/16820 Reviewed-By: Gireesh Punathil Reviewed-By: Rich Trott --- test/addons-napi/test_exception/test.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/addons-napi/test_exception/test.js b/test/addons-napi/test_exception/test.js index b8626b4ddd38a2..8bd2f50b12b15f 100644 --- a/test/addons-napi/test_exception/test.js +++ b/test/addons-napi/test_exception/test.js @@ -33,7 +33,8 @@ assert.strictEqual(test_exception.wasPending(), true, // Test that the native side does not capture a non-existing exception returnedError = test_exception.returnException(common.mustCall()); assert.strictEqual(undefined, returnedError, - 'Returned error is undefined when no exception is thrown'); + 'Returned error should be undefined when no exception is' + + ` thrown, but ${returnedError} was passed`); // Test that no exception appears that was not thrown by us try { @@ -42,7 +43,8 @@ try { caughtError = anError; } assert.strictEqual(undefined, caughtError, - 'No exception originated on the native side'); + 'No exception originated on the native side, but' + + ` ${caughtError} was passed`); // Test that the exception state remains clear when no exception is thrown assert.strictEqual(test_exception.wasPending(), false,