From d35648ffc2cb92e730bfc6de871410b170ffebee Mon Sep 17 00:00:00 2001 From: Artur G Vieira Date: Tue, 9 May 2017 06:15:36 +0000 Subject: [PATCH] test: use dynamic port in test-https-connect-address-family Remove common.PORT from test-https-connect-address-family to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12915 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Yuta Hiroto Reviewed-By: Gibson Fahnestock Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig --- test/parallel/test-https-connect-address-family.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-https-connect-address-family.js b/test/parallel/test-https-connect-address-family.js index ab13e060be06ac..e7f41ce861cb27 100644 --- a/test/parallel/test-https-connect-address-family.js +++ b/test/parallel/test-https-connect-address-family.js @@ -19,10 +19,10 @@ function runTest() { https.createServer({ ciphers }, common.mustCall(function(req, res) { this.close(); res.end(); - })).listen(common.PORT, '::1', common.mustCall(function() { + })).listen(0, '::1', common.mustCall(function() { const options = { host: 'localhost', - port: common.PORT, + port: this.address().port, family: 6, ciphers: ciphers, rejectUnauthorized: false,